Starter/samples
1
0
Fork 0
mirror of https://github.com/flutter/samples.git synced 2025-11-08 13:58:47 +00:00
Code Issues Releases Wiki Activity

Adjust lint rules for experimental/web_dashboard (#820)

Browse Source
This commit is contained in:
Brett Morgan
2021-06-08 07:48:36 +10:00
committed by GitHub
parent 9ad1fae51c
commit 40abd00a45
3 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
experimental/web_dashboard/analysis_options.yaml
View File

@@ -7,13 +7,11 @@ analyzer:
linter: linter:
rules: rules:
avoid_print: false
avoid_types_on_closure_parameters: true avoid_types_on_closure_parameters: true
avoid_void_async: true avoid_void_async: true
cancel_subscriptions: true cancel_subscriptions: true
close_sinks: true close_sinks: true
directives_ordering: true directives_ordering: true
file_names: false
package_api_docs: true package_api_docs: true
package_prefixed_library_names: true package_prefixed_library_names: true
test_types_in_equals: true test_types_in_equals: true

3
experimental/web_dashboard/lib/src/auth/firebase.dart
View File

@@ -19,8 +19,7 @@ class FirebaseAuthService implements Auth {
Future<User> signIn() async { Future<User> signIn() async {
try { try {
return await _signIn(); return await _signIn();
} on PlatformException catch (e) { } on PlatformException {
print('Unable to sign in: $e');
throw SignInException(); throw SignInException();
} }
} }

6
experimental/web_dashboard/lib/src/widgets/edit_entry.dart
View File

@@ -89,11 +89,7 @@ class _EditEntryFormState extends State<EditEntryForm> {
return null; return null;
}, },
onChanged: (newValue) { onChanged: (newValue) {
try { widget.entry.value = int.parse(newValue);
widget.entry.value = int.parse(newValue);
} on FormatException {
print('Entry cannot contain "$newValue". Expected a number');
}
}, },
), ),
), ),