Starter/samples
1
0
Fork 0
mirror of https://github.com/flutter/samples.git synced 2025-11-08 13:58:47 +00:00
Code Issues Releases Wiki Activity

Reenable simplistic_editor on CI (#2238)

Browse Source
This commit is contained in:
Parker Lougheed
2024-04-09 03:56:03 -05:00
committed by GitHub
parent ba03527598
commit 5149510f44
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
simplistic_editor/lib/basic_text_input_client.dart
View File

@@ -780,7 +780,8 @@ class BasicTextInputClientState extends State<BasicTextInputClient>
// We return early if the selection is not valid. This can happen when the // We return early if the selection is not valid. This can happen when the
// text of the editable is updated at the same time as the selection is // text of the editable is updated at the same time as the selection is
// changed by a gesture event. // changed by a gesture event.
if (!widget.controller.isSelectionWithinTextBounds(selection)) return; final textLength = _value.text.length;
if (selection.start > textLength || selection.end > textLength) return;
widget.controller.selection = selection; widget.controller.selection = selection;

3
tool/flutter_ci_script_beta.sh
View File

@@ -60,8 +60,7 @@ declare -ar PROJECT_NAMES=(
# "provider_shopper" # "provider_shopper"
"simple_shader" "simple_shader"
"simplistic_calculator" "simplistic_calculator"
# TODO(DomesticMouse): The method 'isSelectionWithinTextBounds' isn't defined for the type 'TextEditingController' "simplistic_editor"
# "simplistic_editor"
"testing_app" "testing_app"
"veggieseasons" "veggieseasons"
"web_embedding/element_embedding_demo" "web_embedding/element_embedding_demo"

3
tool/flutter_ci_script_master.sh
View File

@@ -60,8 +60,7 @@ declare -ar PROJECT_NAMES=(
# "provider_shopper" # "provider_shopper"
"simple_shader" "simple_shader"
"simplistic_calculator" "simplistic_calculator"
# TODO(DomesticMouse): The method 'isSelectionWithinTextBounds' isn't defined for the type 'TextEditingController' "simplistic_editor"
# "simplistic_editor"
"testing_app" "testing_app"
"veggieseasons" "veggieseasons"
"web_embedding/element_embedding_demo" "web_embedding/element_embedding_demo"