Starter/samples
1
0
Fork 0
mirror of https://github.com/flutter/samples.git synced 2025-11-08 22:09:06 +00:00
Code Issues Releases Wiki Activity

Account for new generated rules.json location in linter tool (#1956)

Browse Source 
In preparation for the linter moving to the SDK, the `rules.json` file
is no longer generated to its own location. The site-www version is
better guaranteed to be up to date and match the `stable` release of
Dart.
This commit is contained in:
Parker Lougheed
2023-07-21 19:49:25 -05:00
committed by GitHub
parent 18848bdd84
commit 908e1cce83
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
experimental/linting_tool/lib/repository/api_provider.dart
View File

@@ -8,15 +8,14 @@ import 'package:linting_tool/model/rule.dart';
import 'package:yaml/yaml.dart'; import 'package:yaml/yaml.dart';
class APIProvider { class APIProvider {
static const String _baseURL = 'https://dart-lang.github.io/linter';
final http.Client httpClient; final http.Client httpClient;
APIProvider(this.httpClient); APIProvider(this.httpClient);
Future<List<Rule>> getRulesList() async { Future<List<Rule>> getRulesList() async {
final response = final response = await httpClient.get(Uri.parse(
await httpClient.get(Uri.parse('$_baseURL/lints/machine/rules.json')); 'https://raw.githubusercontent.com/dart-lang/site-www/main/src/_data/linter_rules.json',
));
if (response.statusCode == 200) { if (response.statusCode == 200) {
final data = json.decode(response.body) as List; final data = json.decode(response.body) as List;

4
experimental/linting_tool/test/widget_test.dart
View File

@@ -75,8 +75,8 @@ void main() {
'''[{"name": "always_use_package_imports","description": "Avoid relative imports for files in `lib/`.","group": "errors","state": "stable","incompatible": [],"sets": [],"details": "*DO* avoid relative imports for files in `lib/`.\n\nWhen mixing relative and absolute imports it's possible to create confusion\nwhere the same member gets imported in two different ways. One way to avoid\nthat is to ensure you consistently use absolute imports for files withing the\n`lib/` directory.\n\nThis is the opposite of 'prefer_relative_imports'.\nMight be used with 'avoid_relative_lib_imports' to avoid relative imports of\nfiles within `lib/` directory outside of it. (for example `test/`)\n\n**GOOD:**\n\n```dart\nimport 'package:foo/bar.dart';\n\nimport 'package:foo/baz.dart';\n\nimport 'package:foo/src/baz.dart';\n...\n```\n\n**BAD:**\n\n```dart\nimport 'baz.dart';\n\nimport 'src/bag.dart'\n\nimport '../lib/baz.dart';\n\n...\n```\n\n"}]'''; '''[{"name": "always_use_package_imports","description": "Avoid relative imports for files in `lib/`.","group": "errors","state": "stable","incompatible": [],"sets": [],"details": "*DO* avoid relative imports for files in `lib/`.\n\nWhen mixing relative and absolute imports it's possible to create confusion\nwhere the same member gets imported in two different ways. One way to avoid\nthat is to ensure you consistently use absolute imports for files withing the\n`lib/` directory.\n\nThis is the opposite of 'prefer_relative_imports'.\nMight be used with 'avoid_relative_lib_imports' to avoid relative imports of\nfiles within `lib/` directory outside of it. (for example `test/`)\n\n**GOOD:**\n\n```dart\nimport 'package:foo/bar.dart';\n\nimport 'package:foo/baz.dart';\n\nimport 'package:foo/src/baz.dart';\n...\n```\n\n**BAD:**\n\n```dart\nimport 'baz.dart';\n\nimport 'src/bag.dart'\n\nimport '../lib/baz.dart';\n\n...\n```\n\n"}]''';
when(_mockClient.get(Uri.parse( when(_mockClient.get(Uri.parse(
'https://dart-lang.github.io/linter/lints/machine/rules.json'))) 'https://raw.githubusercontent.com/dart-lang/site-www/main/src/_data/linter_rules.json',
.thenAnswer( ))).thenAnswer(
(_) async => http.Response(responseBody, 400), (_) async => http.Response(responseBody, 400),
); );