Add flutter_lints (#809)

add_to_app/android_view/flutter_module_using_plugin/analysis_options.yaml

@@ -0,0 +1,19 @@
+include: package:flutter_lints/flutter.yaml
+
+analyzer:
+  strong-mode:
+    implicit-casts: false
+    implicit-dynamic: false
+
+linter:
+  rules:
+    avoid_types_on_closure_parameters: true
+    avoid_void_async: true
+    cancel_subscriptions: true
+    close_sinks: true
+    directives_ordering: true
+    package_api_docs: true
+    package_prefixed_library_names: true
+    test_types_in_equals: true
+    throw_in_finally: true
+    unnecessary_statements: true

add_to_app/android_view/flutter_module_using_plugin/lib/cell.dart

@@ -11,12 +11,14 @@ import 'package:sensors/sensors.dart';
 // This is on alternate entrypoint for this module to display Flutter UI in
 // a (multi-)view integration scenario.
 void main() {
-  runApp(Cell());
+  runApp(const Cell());
 }
 
 class Cell extends StatefulWidget {
+  const Cell({Key key}) : super(key: key);
+
   @override
-  State<StatefulWidget> createState() => new _CellState();
+  State<StatefulWidget> createState() => _CellState();
 }
 
 class _CellState extends State<Cell> with WidgetsBindingObserver {
@@ -29,8 +31,8 @@ class _CellState extends State<Cell> with WidgetsBindingObserver {
 
   @override
   void initState() {
-    final channel = MethodChannel('dev.flutter.example/cell');
+    const channel = MethodChannel('dev.flutter.example/cell');
-    channel.setMethodCallHandler((MethodCall call) async {
+    channel.setMethodCallHandler((call) async {
       if (call.method == 'setCellNumber') {
         setState(() {
           cellNumber = call.arguments as int;
@@ -73,10 +75,10 @@ class _CellState extends State<Cell> with WidgetsBindingObserver {
       home: Container(
         color: Colors.white,
         child: Builder(
-          builder: (BuildContext context) {
+          builder: (context) {
             return Card(
               // Mimic the platform Material look.
-              margin: EdgeInsets.symmetric(horizontal: 36, vertical: 24),
+              margin: const EdgeInsets.symmetric(horizontal: 36, vertical: 24),
               shape: RoundedRectangleBorder(
                 borderRadius: BorderRadius.circular(16),
               ),
@@ -103,15 +105,14 @@ class _CellState extends State<Cell> with WidgetsBindingObserver {
                     bottom: 0,
                     child: Opacity(
                       opacity: 0.2,
-                      child: StreamBuilder(
+                      child: StreamBuilder<AccelerometerEvent>(
                         // Don't continuously rebuild for nothing when the
                         // cell isn't visible.
                         stream: appLifecycleState == AppLifecycleState.resumed
                             ? accelerometerEvents
                             : Stream.value(defaultPosition),
                         initialData: defaultPosition,
-                        builder: (BuildContext context,
+                        builder: (context, snapshot) {
-                            AsyncSnapshot<AccelerometerEvent> snapshot) {
                           return Transform(
                               // Figure out the phone's orientation relative
                               // to gravity's direction. Ignore the z vector.
@@ -120,7 +121,7 @@ class _CellState extends State<Cell> with WidgetsBindingObserver {
                                 ..multiply(Matrix4.rotationY(
                                     snapshot.data.x / gravity * pi / 2)),
                               alignment: Alignment.center,
-                              child: FlutterLogo(size: 72));
+                              child: const FlutterLogo(size: 72));
                         },
                       ),
                     ),

add_to_app/android_view/flutter_module_using_plugin/lib/main.dart

@@ -20,7 +20,7 @@ void main() {
   runApp(
     ChangeNotifierProvider.value(
       value: model,
-      child: MyApp(),
+      child: const MyApp(),
     ),
   );
 }
@@ -31,7 +31,7 @@ void main() {
 // https://github.com/flutter/flutter/issues/72630.
 @pragma("vm:entry-point")
 void showCell() {
-  runApp(Cell());
+  runApp(const Cell());
 }
 
 /// A simple model that uses a [MethodChannel] as the source of truth for the
@@ -44,17 +44,17 @@ void showCell() {
 class CounterModel extends ChangeNotifier {
   CounterModel() {
     _channel.setMethodCallHandler(_handleMessage);
-    _channel.invokeMethod('requestCounter');
+    _channel.invokeMethod<void>('requestCounter');
   }
 
-  final _channel = MethodChannel('dev.flutter.example/counter');
+  final _channel = const MethodChannel('dev.flutter.example/counter');
 
   int _count = 0;
 
   int get count => _count;
 
   void increment() {
-    _channel.invokeMethod('incrementCounter');
+    _channel.invokeMethod<void>('incrementCounter');
   }
 
   Future<dynamic> _handleMessage(MethodCall call) async {
@@ -70,13 +70,15 @@ class CounterModel extends ChangeNotifier {
 /// It offers two routes, one suitable for displaying as a full screen and
 /// another designed to be part of a larger UI.
 class MyApp extends StatelessWidget {
+  const MyApp({Key key}) : super(key: key);
+
   @override
   Widget build(BuildContext context) {
     return MaterialApp(
       title: 'Flutter Module Title',
       routes: {
-        '/': (context) => FullScreenView(),
+        '/': (context) => const FullScreenView(),
-        '/mini': (context) => Contents(),
+        '/mini': (context) => const Contents(),
       },
     );
   }
@@ -85,11 +87,13 @@ class MyApp extends StatelessWidget {
 /// Wraps [Contents] in a Material [Scaffold] so it looks correct when displayed
 /// full-screen.
 class FullScreenView extends StatelessWidget {
+  const FullScreenView({Key key}) : super(key: key);
+
   @override
   Widget build(BuildContext context) {
     return Scaffold(
       appBar: AppBar(
-        title: Text('Full-screen Flutter with plugin'),
+        title: const Text('Full-screen Flutter with plugin'),
       ),
       body: const Contents(showExit: true),
     );
@@ -105,7 +109,7 @@ class FullScreenView extends StatelessWidget {
 class Contents extends StatelessWidget {
   final bool showExit;
 
-  const Contents({this.showExit = false});
+  const Contents({this.showExit = false, Key key}) : super(key: key);
 
   @override
   Widget build(BuildContext context) {
@@ -121,7 +125,7 @@ class Contents extends StatelessWidget {
               ),
             ),
           ),
-          Positioned.fill(
+          const Positioned.fill(
             child: Opacity(
               opacity: .25,
               child: FittedBox(
@@ -139,7 +143,7 @@ class Contents extends StatelessWidget {
                   '${mediaInfo.size.height.toStringAsFixed(1)}',
                   style: Theme.of(context).textTheme.headline5,
                 ),
-                SizedBox(height: 16),
+                const SizedBox(height: 16),
                 Consumer<CounterModel>(
                   builder: (context, model, child) {
                     return Text(
@@ -148,12 +152,12 @@ class Contents extends StatelessWidget {
                     );
                   },
                 ),
-                SizedBox(height: 16),
+                const SizedBox(height: 16),
                 Consumer<CounterModel>(
                   builder: (context, model, child) {
                     return ElevatedButton(
                       onPressed: () => model.increment(),
-                      child: Text('Tap me!'),
+                      child: const Text('Tap me!'),
                     );
                   },
                 ),
@@ -161,18 +165,18 @@ class Contents extends StatelessWidget {
                   onPressed: () async {
                     // Use the url_launcher plugin to open the Flutter docs in
                     // a browser.
-                    final url = 'https://flutter.dev/docs';
+                    const url = 'https://flutter.dev/docs';
                     if (await launcher.canLaunch(url)) {
                       launcher.launch(url);
                     }
                   },
-                  child: Text('Open Flutter Docs'),
+                  child: const Text('Open Flutter Docs'),
                 ),
                 if (showExit) ...[
-                  SizedBox(height: 16),
+                  const SizedBox(height: 16),
                   ElevatedButton(
                     onPressed: () => SystemNavigator.pop(),
-                    child: Text('Exit this screen'),
+                    child: const Text('Exit this screen'),
                   ),
                 ],
               ],

add_to_app/android_view/flutter_module_using_plugin/pubspec.lock

@@ -7,7 +7,7 @@ packages:
       name: async
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.5.0"
+    version: "2.6.1"
   boolean_selector:
     dependency: transitive
     description:
@@ -55,6 +55,13 @@ packages:
     description: flutter
     source: sdk
     version: "0.0.0"
+  flutter_lints:
+    dependency: "direct dev"
+    description:
+      name: flutter_lints
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.3"
   flutter_test:
     dependency: "direct dev"
     description: flutter
@@ -72,6 +79,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "0.6.3"
+  lints:
+    dependency: transitive
+    description:
+      name: lints
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.1"
   matcher:
     dependency: transitive
     description:
@@ -167,7 +181,7 @@ packages:
       name: test_api
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.2.19"
+    version: "0.3.0"
   typed_data:
     dependency: transitive
     description:
@@ -225,5 +239,5 @@ packages:
     source: hosted
     version: "2.1.0"
 sdks:
-  dart: ">=2.12.0-0.0 <3.0.0"
+  dart: ">=2.12.0 <3.0.0"
   flutter: ">=1.22.0"

add_to_app/android_view/flutter_module_using_plugin/pubspec.yaml

@@ -16,6 +16,7 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
+  flutter_lints: ^1.0.0
 
 flutter:
   uses-material-design: true

add_to_app/android_view/flutter_module_using_plugin/test/widget_test.dart

@@ -14,8 +14,10 @@ import 'package:provider/provider.dart';
 class MockCounterModel extends ChangeNotifier implements CounterModel {
   int _count = 0;
 
+  @override
   int get count => _count;
 
+  @override
   void increment() {
     _count++;
     notifyListeners();
@@ -23,13 +25,13 @@ class MockCounterModel extends ChangeNotifier implements CounterModel {
 }
 
 void main() {
-  testWidgets('MiniView smoke test', (WidgetTester tester) async {
+  testWidgets('MiniView smoke test', (tester) async {
     // Build our app and trigger a frame.
     await tester.pumpWidget(
       MaterialApp(
         home: ChangeNotifierProvider<CounterModel>.value(
           value: MockCounterModel(),
-          child: Contents(),
+          child: const Contents(),
         ),
       ),
     );