Starter/samples
1
0
Fork 0
mirror of https://github.com/flutter/samples.git synced 2025-11-08 22:09:06 +00:00
Code Issues Releases Wiki Activity

Drop redundant ToggleButtonsStateManager instances (#1305)

Browse Source
This commit is contained in:
Brett Morgan
2022-06-16 15:02:14 +10:00
committed by GitHub
parent e3040c9e36
commit addafa93ec
1 changed files with 31 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
simplistic_editor/lib/main.dart
View File

@@ -310,13 +310,7 @@ class _MyHomePageState extends State<MyHomePage> {
child: Row( child: Row(
mainAxisAlignment: MainAxisAlignment.center, mainAxisAlignment: MainAxisAlignment.center,
children: [ children: [
ToggleButtonsStateManager( Builder(builder: (innerContext) {
isToggleButtonsSelected: _isSelected,
updateToggleButtonsStateOnButtonPressed:
_updateToggleButtonsStateOnButtonPressed,
updateToggleButtonStateOnSelectionChanged:
_updateToggleButtonsStateOnSelectionChanged,
child: Builder(builder: (innerContext) {
final ToggleButtonsStateManager manager = final ToggleButtonsStateManager manager =
ToggleButtonsStateManager.of(innerContext); ToggleButtonsStateManager.of(innerContext);
@@ -331,8 +325,8 @@ class _MyHomePageState extends State<MyHomePage> {
manager.toggleButtonsState manager.toggleButtonsState
.contains(ToggleButtonsState.underline), .contains(ToggleButtonsState.underline),
], ],
onPressed: (index) => manager onPressed: (index) =>
.updateToggleButtonsOnButtonPressed(index), manager.updateToggleButtonsOnButtonPressed(index),
children: const [ children: const [
Icon(Icons.format_bold), Icon(Icons.format_bold),
Icon(Icons.format_italic), Icon(Icons.format_italic),
@@ -340,19 +334,12 @@ class _MyHomePageState extends State<MyHomePage> {
], ],
); );
}), }),
),
], ],
), ),
), ),
Expanded( Expanded(
child: Padding( child: Padding(
padding: const EdgeInsets.symmetric(horizontal: 35.0), padding: const EdgeInsets.symmetric(horizontal: 35.0),
child: ToggleButtonsStateManager(
isToggleButtonsSelected: _isSelected,
updateToggleButtonsStateOnButtonPressed:
_updateToggleButtonsStateOnButtonPressed,
updateToggleButtonStateOnSelectionChanged:
_updateToggleButtonsStateOnSelectionChanged,
child: TextEditingDeltaHistoryManager( child: TextEditingDeltaHistoryManager(
history: _textEditingDeltaHistory, history: _textEditingDeltaHistory,
updateHistoryOnInput: _updateTextEditingDeltaHistory, updateHistoryOnInput: _updateTextEditingDeltaHistory,
@@ -365,7 +352,6 @@ class _MyHomePageState extends State<MyHomePage> {
), ),
), ),
), ),
),
Expanded( Expanded(
child: Column( child: Column(
children: [ children: [