Starter/samples
1
0
Fork 0
mirror of https://github.com/flutter/samples.git synced 2025-11-09 14:28:51 +00:00
Code Issues Releases Wiki Activity

Enable copy to clipboard for web, as it's added to Flutter master channel (#253)

Browse Source
This commit is contained in:
Per Classon
2020-01-24 12:50:01 +01:00
committed by GitHub
parent 7f783273c3
commit be484af4d2
1 changed files with 27 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
gallery/gallery/lib/pages/demo.dart
View File

@@ -299,10 +299,6 @@ class _DemoPageState extends State<DemoPage> with TickerProviderStateMixin {
maxHeight: maxSectionHeight, maxHeight: maxSectionHeight,
codeWidget: CodeDisplayPage( codeWidget: CodeDisplayPage(
_currentConfig.code, _currentConfig.code,
hasCopyButton:
!kIsWeb, // TODO: Add support for copying code in Web.
// TODO: It is a known issue that Clipboard does not work on web.
// TODO: https://github.com/flutter/flutter/issues/40124
), ),
), ),
); );
@@ -701,10 +697,9 @@ class _DemoSectionCode extends StatelessWidget {
} }
class CodeDisplayPage extends StatelessWidget { class CodeDisplayPage extends StatelessWidget {
const CodeDisplayPage(this.code, {this.hasCopyButton = true}); const CodeDisplayPage(this.code);
final CodeDisplayer code; final CodeDisplayer code;
final bool hasCopyButton;
Widget build(BuildContext context) { Widget build(BuildContext context) {
final isDesktop = isDisplayDesktop(context); final isDesktop = isDisplayDesktop(context);
@@ -723,7 +718,7 @@ class CodeDisplayPage extends StatelessWidget {
); );
} }
void _showSnackBarOnCopyFailure(Exception exception) { void _showSnackBarOnCopyFailure(Object exception) {
Scaffold.of(context).showSnackBar( Scaffold.of(context).showSnackBar(
SnackBar( SnackBar(
content: Text( content: Text(
@@ -737,32 +732,33 @@ class CodeDisplayPage extends StatelessWidget {
return Column( return Column(
crossAxisAlignment: CrossAxisAlignment.start, crossAxisAlignment: CrossAxisAlignment.start,
children: [ children: [
if (hasCopyButton) Padding(
Padding( padding: isDesktop
padding: isDesktop ? EdgeInsets.only(bottom: 8)
? EdgeInsets.only(bottom: 8) : EdgeInsets.symmetric(vertical: 8),
: EdgeInsets.symmetric(vertical: 8), child: FlatButton(
child: FlatButton( color: Colors.white.withOpacity(0.15),
color: Colors.white.withOpacity(0.15), materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
materialTapTargetSize: MaterialTapTargetSize.shrinkWrap, padding: EdgeInsets.symmetric(horizontal: 8),
padding: EdgeInsets.symmetric(horizontal: 8), shape: RoundedRectangleBorder(
shape: RoundedRectangleBorder( borderRadius: BorderRadius.all(Radius.circular(4)),
borderRadius: BorderRadius.all(Radius.circular(4)), ),
), onPressed: () async {
onPressed: () async { // The future will not complete on web, thus no
await Clipboard.setData(ClipboardData(text: _plainTextCode)) // Snackbar will be shown, see https://github.com/flutter/flutter/issues/49349.
.then(_showSnackBarOnCopySuccess) await Clipboard.setData(ClipboardData(text: _plainTextCode))
.catchError(_showSnackBarOnCopyFailure); .then(_showSnackBarOnCopySuccess)
}, .catchError(_showSnackBarOnCopyFailure);
child: Text( },
GalleryLocalizations.of(context).demoCodeViewerCopyAll, child: Text(
style: Theme.of(context).textTheme.button.copyWith( GalleryLocalizations.of(context).demoCodeViewerCopyAll,
color: Colors.white, style: Theme.of(context).textTheme.button.copyWith(
fontWeight: FontWeight.w500, color: Colors.white,
), fontWeight: FontWeight.w500,
), ),
), ),
), ),
),
Expanded( Expanded(
child: SingleChildScrollView( child: SingleChildScrollView(
child: Container( child: Container(