Starter/samples
1
0
Fork 0
mirror of https://github.com/flutter/samples.git synced 2026-04-21 22:43:06 +00:00
Code Issues Releases Wiki Activity

Some linting_tool updates and cleanup (#1279)

Browse Source
This commit is contained in:
Parker Lougheed
2022-05-22 23:48:16 -05:00
committed by GitHub
parent 50863c5b63
commit d6296157f4
24 changed files with 187 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
experimental/linting_tool/lib/pages/default_lints_page.dart
View File

@@ -20,8 +20,8 @@ class DefaultLintsPage extends StatelessWidget {
return const CircularProgressIndicator.adaptive();
}
if (rulesStore.defaultProfiles.isNotEmpty) {
var defaultSets = rulesStore.defaultProfiles;
final defaultSets = rulesStore.defaultProfiles;
if (defaultSets.isNotEmpty) {
final isDesktop = isDisplayLarge(context);
final isTablet = isDisplayMedium(context);
final startPadding = isTablet
@@ -45,7 +45,7 @@ class DefaultLintsPage extends StatelessWidget {
cacheExtent: 5,
itemCount: defaultSets.length,
itemBuilder: (context, index) {
var profile = rulesStore.defaultProfiles[index];
final profile = defaultSets[index];
return ListTile(
title: Text(
profile.name,

2
experimental/linting_tool/lib/pages/default_rules_page.dart
View File

@@ -20,7 +20,7 @@ class DefaultRulesPage extends StatelessWidget {
Widget build(BuildContext context) {
final isDesktop = isDisplayLarge(context);
final isTablet = isDisplayMedium(context);
var textTheme = Theme.of(context).textTheme;
final textTheme = Theme.of(context).textTheme;
final startPadding = isTablet
? 60.0
: isDesktop

60
experimental/linting_tool/lib/pages/home_page.dart
View File

@@ -19,38 +19,36 @@ class HomePage extends StatelessWidget {
return const CircularProgressIndicator.adaptive();
}
if (!rulesStore.isLoading) {
if (rulesStore.rules.isNotEmpty) {
final isDesktop = isDisplayLarge(context);
final isTablet = isDisplayMedium(context);
final startPadding = isTablet
? 60.0
: isDesktop
? 120.0
: 16.0;
final endPadding = isTablet
? 60.0
: isDesktop
? 120.0
: 16.0;
if (rulesStore.rules.isNotEmpty) {
final isDesktop = isDisplayLarge(context);
final isTablet = isDisplayMedium(context);
final startPadding = isTablet
? 60.0
: isDesktop
? 120.0
: 16.0;
final endPadding = isTablet
? 60.0
: isDesktop
? 120.0
: 16.0;
return ListView.separated(
padding: EdgeInsetsDirectional.only(
start: startPadding,
end: endPadding,
top: isDesktop ? 28 : 16,
bottom: isDesktop ? kToolbarHeight : 16,
),
itemCount: rulesStore.rules.length,
cacheExtent: 5,
itemBuilder: (context, index) {
return LintExpansionTile(
rule: rulesStore.rules[index],
);
},
separatorBuilder: (context, index) => const SizedBox(height: 4),
);
}
return ListView.separated(
padding: EdgeInsetsDirectional.only(
start: startPadding,
end: endPadding,
top: isDesktop ? 28 : 16,
bottom: isDesktop ? kToolbarHeight : 16,
),
itemCount: rulesStore.rules.length,
cacheExtent: 5,
itemBuilder: (context, index) {
return LintExpansionTile(
rule: rulesStore.rules[index],
);
},
separatorBuilder: (context, index) => const SizedBox(height: 4),
);
}
return Column(

4
experimental/linting_tool/lib/pages/rules_page.dart
View File

@@ -23,7 +23,7 @@ class RulesPage extends StatelessWidget {
Widget build(BuildContext context) {
final isDesktop = isDisplayLarge(context);
final isTablet = isDisplayMedium(context);
var textTheme = Theme.of(context).textTheme;
final textTheme = Theme.of(context).textTheme;
final startPadding = isTablet
? 60.0
: isDesktop
@@ -85,7 +85,7 @@ class RulesPage extends StatelessWidget {
itemCount: profile.rules.length,
cacheExtent: 5,
itemBuilder: (context, index) {
/// Show righ-click context menu to delete rule.
/// Show right-click context menu to delete rule.
return ContextMenuRegion(
contextMenu: GenericContextMenu(
buttonConfigs: [