Starter/samples
1
0
Fork 0
mirror of https://github.com/flutter/samples.git synced 2025-11-08 13:58:47 +00:00
Code Issues Releases Wiki Activity

Enforce use_key_in_widget_constructors and file_names lints (#913)

Browse Source 
* Start enforcing use_key_in_widget_constructors and file_names lints

* dart format

* analysis fixes

* analysis fixes, pt2

* analysis fixes, part 3

* Revert platform_design (test failure)

* More reverts

* Notate why we aren't enforcing a lint
This commit is contained in:
Brett Morgan
2021-10-09 08:30:28 +11:00
committed by GitHub
parent e160f5261c
commit e2e2713986
69 changed files with 174 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
testing_app/integration_test/app_test.dart
View File

@@ -12,7 +12,7 @@ void main() {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
testWidgets('Finding an item in the list', (tester) async {
await tester.pumpWidget(TestingApp());
await tester.pumpWidget(const TestingApp());
// Create variables for finders that are used multiple times.
final itemFinder = find.byKey(const ValueKey('text_25'));
@@ -28,7 +28,7 @@ void main() {
});
testWidgets('Testing IconButtons', (tester) async {
await tester.pumpWidget(TestingApp());
await tester.pumpWidget(const TestingApp());
// Create a finder for the icon.
final iconFinder = find.byKey(const ValueKey('icon_0'));
@@ -51,7 +51,7 @@ void main() {
testWidgets('Verifying whether item gets added to favorites',
(tester) async {
await tester.pumpWidget(TestingApp());
await tester.pumpWidget(const TestingApp());
// Add item to favorites.
await tester.tap(find.byKey(const ValueKey('icon_5')));
@@ -71,7 +71,7 @@ void main() {
});
testWidgets('Testing remove button', (tester) async {
await tester.pumpWidget(TestingApp());
await tester.pumpWidget(const TestingApp());
// Add item to favorites.
await tester.tap(find.byKey(const ValueKey('icon_5')));

4
testing_app/integration_test/perf_test.dart
View File

@@ -17,7 +17,7 @@ void main() {
binding.framePolicy = LiveTestWidgetsFlutterBindingFramePolicy.fullyLive;
testWidgets('Scrolling test', (tester) async {
await tester.pumpWidget(TestingApp());
await tester.pumpWidget(const TestingApp());
// Create variables for finders that are used multiple times.
final listFinder = find.byType(ListView);
@@ -49,7 +49,7 @@ void main() {
});
testWidgets('Favorites operations test', (tester) async {
await tester.pumpWidget(TestingApp());
await tester.pumpWidget(const TestingApp());
// Record the performance summary as operations are performed
// on the favorites list.

2
testing_app/integration_test/state_mgmt_test.dart
View File

@@ -16,7 +16,7 @@ Widget createFavoritesScreen() => ChangeNotifierProvider<Favorites>(
favoritesList = Favorites();
return favoritesList;
},
child: MaterialApp(
child: const MaterialApp(
home: FavoritesPage(),
),
);