1
0
mirror of https://github.com/flutter/samples.git synced 2025-11-08 13:58:47 +00:00

Enforce use_key_in_widget_constructors and file_names lints (#913)

* Start enforcing use_key_in_widget_constructors and file_names lints

* dart format

* analysis fixes

* analysis fixes, pt2

* analysis fixes, part 3

* Revert platform_design (test failure)

* More reverts

* Notate why we aren't enforcing a lint
This commit is contained in:
Brett Morgan
2021-10-09 08:30:28 +11:00
committed by GitHub
parent e160f5261c
commit e2e2713986
69 changed files with 174 additions and 114 deletions

View File

@@ -9,10 +9,12 @@ import 'package:testing_app/screens/favorites.dart';
import 'package:testing_app/screens/home.dart';
void main() {
runApp(TestingApp());
runApp(const TestingApp());
}
class TestingApp extends StatelessWidget {
const TestingApp({Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {
return ChangeNotifierProvider<Favorites>(
@@ -24,8 +26,8 @@ class TestingApp extends StatelessWidget {
visualDensity: VisualDensity.adaptivePlatformDensity,
),
routes: {
HomePage.routeName: (context) => HomePage(),
FavoritesPage.routeName: (context) => FavoritesPage(),
HomePage.routeName: (context) => const HomePage(),
FavoritesPage.routeName: (context) => const FavoritesPage(),
},
initialRoute: HomePage.routeName,
),

View File

@@ -9,6 +9,8 @@ import 'package:testing_app/models/favorites.dart';
class FavoritesPage extends StatelessWidget {
static String routeName = '/favorites_page';
const FavoritesPage({Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {
return Scaffold(
@@ -34,9 +36,7 @@ class FavoritesPage extends StatelessWidget {
class FavoriteItemTile extends StatelessWidget {
final int itemNo;
const FavoriteItemTile(
this.itemNo,
);
const FavoriteItemTile(this.itemNo, {Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {

View File

@@ -10,6 +10,8 @@ import 'package:testing_app/screens/favorites.dart';
class HomePage extends StatelessWidget {
static String routeName = '/';
const HomePage({Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {
return Scaffold(
@@ -40,9 +42,7 @@ class HomePage extends StatelessWidget {
class ItemTile extends StatelessWidget {
final int itemNo;
const ItemTile(
this.itemNo,
);
const ItemTile(this.itemNo, {Key? key}) : super(key: key);
@override
Widget build(BuildContext context) {