Enable some extra lints for compass app client (#2560)

Enable a few more lints that were mostly followed already for
consistency.

compass_app/app/lib/ui/auth/logout/view_models/logout_viewmodel.dart

@@ -21,7 +21,7 @@ class LogoutViewModel {
   late Command0 logout;
 
   Future<Result> _logout() async {
-    var result = await _authLogoutRepository.logout();
+    final result = await _authLogoutRepository.logout();
     switch (result) {
       case Ok<void>():
         // clear stored itinerary config

compass_app/app/lib/ui/booking/view_models/booking_viewmodel.dart

@@ -9,10 +9,10 @@ import '../../../data/repositories/booking/booking_repository.dart';
 import '../../../data/repositories/itinerary_config/itinerary_config_repository.dart';
 import '../../../domain/models/booking/booking.dart';
 import '../../../domain/models/itinerary_config/itinerary_config.dart';
-import '../../../utils/command.dart';
-import '../../../utils/result.dart';
 import '../../../domain/use_cases/booking/booking_create_use_case.dart';
 import '../../../domain/use_cases/booking/booking_share_use_case.dart';
+import '../../../utils/command.dart';
+import '../../../utils/result.dart';
 
 class BookingViewModel extends ChangeNotifier {
   BookingViewModel({

compass_app/app/lib/ui/core/themes/dimens.dart

@@ -29,8 +29,8 @@ abstract final class Dimens {
   EdgeInsets get edgeInsetsScreenSymmetric => EdgeInsets.symmetric(
       horizontal: paddingScreenHorizontal, vertical: paddingScreenVertical);
 
-  static final Dimens desktop = _DimensDesktop();
-  static final Dimens mobile = _DimensMobile();
+  static const Dimens desktop = _DimensDesktop();
+  static const Dimens mobile = _DimensMobile();
 
   /// Get dimensions definition based on screen size
   factory Dimens.of(BuildContext context) =>
@@ -50,6 +50,8 @@ final class _DimensMobile extends Dimens {
 
   @override
   final double profilePictureSize = 64.0;
+
+  const _DimensMobile();
 }
 
 /// Desktop/Web dimensions
@@ -62,4 +64,6 @@ final class _DimensDesktop extends Dimens {
 
   @override
   final double profilePictureSize = 128.0;
+
+  const _DimensDesktop();
 }

compass_app/app/lib/ui/core/themes/theme.dart

@@ -2,10 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import 'colors.dart';
-import '../ui/tag_chip.dart';
 import 'package:flutter/material.dart';
 
+import '../ui/tag_chip.dart';
+import 'colors.dart';
+
 abstract final class AppTheme {
   static const _textTheme = TextTheme(
     headlineLarge: TextStyle(

compass_app/app/lib/ui/core/ui/search_bar.dart

@@ -80,7 +80,9 @@ class _QueryText extends StatelessWidget {
     }
 
     return Text(
-      '$continent - ${dateFormatStartEnd(DateTimeRange(start: startDate, end: endDate))} - Guests: $guests',
+      '$continent - '
+      '${dateFormatStartEnd(DateTimeRange(start: startDate, end: endDate))} - '
+      'Guests: $guests',
       textAlign: TextAlign.center,
       style: Theme.of(context).textTheme.bodyLarge,
     );

compass_app/app/lib/ui/core/ui/tag_chip.dart

@@ -4,10 +4,11 @@
 
 import 'dart:ui';
 
-import '../themes/colors.dart';
 import 'package:flutter/material.dart';
 import 'package:google_fonts/google_fonts.dart';
 
+import '../themes/colors.dart';
+
 class TagChip extends StatelessWidget {
   const TagChip({
     super.key,
@@ -96,7 +97,7 @@ class TagChip extends StatelessWidget {
 
   // Note: original Figma file uses Google Sans
   // which is not available on GoogleFonts
-  _textStyle(BuildContext context) => GoogleFonts.openSans(
+  TextStyle _textStyle(BuildContext context) => GoogleFonts.openSans(
         textStyle: TextStyle(
           fontWeight: FontWeight.w500,
           fontSize: fontSize,

compass_app/app/lib/ui/home/widgets/home_screen.dart

@@ -169,11 +169,11 @@ class _Booking extends StatelessWidget {
       confirmDismiss: confirmDismiss,
       background: Container(
         color: AppColors.grey1,
-        child: Row(
+        child: const Row(
           mainAxisAlignment: MainAxisAlignment.end,
           children: [
             Padding(
-              padding: const EdgeInsets.only(right: Dimens.paddingHorizontal),
+              padding: EdgeInsets.only(right: Dimens.paddingHorizontal),
               child: Icon(Icons.delete),
             ),
           ],

compass_app/app/lib/ui/results/view_models/results_viewmodel.dart

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import 'package:flutter/cupertino.dart';
 import 'package:logging/logging.dart';
 
 import '../../../data/repositories/destination/destination_repository.dart';
@@ -10,7 +11,6 @@ import '../../../domain/models/destination/destination.dart';
 import '../../../domain/models/itinerary_config/itinerary_config.dart';
 import '../../../utils/command.dart';
 import '../../../utils/result.dart';
-import 'package:flutter/cupertino.dart';
 
 /// Results screen view model
 /// Based on https://docs.flutter.dev/get-started/fwe/state-management#using-mvvm-for-your-applications-architecture

compass_app/app/lib/ui/search_form/widgets/search_form_date.dart

@@ -5,9 +5,9 @@
 import 'package:flutter/material.dart';
 
 import '../../core/localization/applocalization.dart';
+import '../../core/themes/colors.dart';
 import '../../core/themes/dimens.dart';
 import '../../core/ui/date_format_start_end.dart';
-import '../../core/themes/colors.dart';
 import '../view_models/search_form_viewmodel.dart';
 
 /// Date selection form field.

compass_app/app/lib/ui/search_form/widgets/search_form_screen.dart

@@ -10,9 +10,9 @@ import '../../core/themes/dimens.dart';
 import '../../core/ui/search_bar.dart';
 import '../../results/widgets/results_screen.dart';
 import '../view_models/search_form_viewmodel.dart';
+import 'search_form_continent.dart';
 import 'search_form_date.dart';
 import 'search_form_guests.dart';
-import 'search_form_continent.dart';
 import 'search_form_submit.dart';
 
 /// Search form screen