Starter/samples
1
0
Fork 0
mirror of https://github.com/flutter/samples.git synced 2026-03-31 16:55:34 +00:00
Code Issues Releases Wiki Activity

Enable some extra lints for compass app client (#2560)

Browse Source 
Enable a few more lints that were mostly followed already for
consistency.
This commit is contained in:
Parker Lougheed
2025-01-06 21:58:52 +08:00
committed by GitHub
parent e36c642199
commit e39638ebff
31 changed files with 65 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
compass_app/app/test/data/repositories/destination/destination_repository_local_test.dart
View File

@@ -2,9 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:compass_app/data/repositories/destination/destination_repository_local.dart';
import 'package:compass_app/data/services/local/local_data_service.dart';
import 'package:compass_app/utils/result.dart';
import 'package:compass_app/data/repositories/destination/destination_repository_local.dart';
import 'package:flutter_test/flutter_test.dart';
import '../../../../testing/utils/result.dart';

2
compass_app/app/test/domain/use_cases/booking/booking_create_use_case_test.dart
View File

@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:compass_app/domain/use_cases/booking/booking_create_use_case.dart';
import 'package:compass_app/domain/models/itinerary_config/itinerary_config.dart';
import 'package:compass_app/domain/use_cases/booking/booking_create_use_case.dart';
import 'package:flutter_test/flutter_test.dart';
import '../../../../testing/fakes/repositories/fake_activities_repository.dart';

2
compass_app/app/test/domain/use_cases/booking/booking_share_use_case_test.dart
View File

@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:compass_app/domain/use_cases/booking/booking_share_use_case.dart';
import 'package:compass_app/domain/models/booking/booking.dart';
import 'package:compass_app/domain/use_cases/booking/booking_share_use_case.dart';
import 'package:flutter_test/flutter_test.dart';
import '../../../../testing/models/activity.dart';

2
compass_app/app/test/ui/booking/booking_screen_test.dart
View File

@@ -2,9 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:compass_app/domain/models/itinerary_config/itinerary_config.dart';
import 'package:compass_app/domain/use_cases/booking/booking_create_use_case.dart';
import 'package:compass_app/domain/use_cases/booking/booking_share_use_case.dart';
import 'package:compass_app/domain/models/itinerary_config/itinerary_config.dart';
import 'package:compass_app/ui/booking/view_models/booking_viewmodel.dart';
import 'package:compass_app/ui/booking/widgets/booking_screen.dart';
import 'package:flutter/foundation.dart';

2
compass_app/app/test/ui/home/widgets/home_screen_test.dart
View File

@@ -37,7 +37,7 @@ void main() {
when(() => goRouter.push(any())).thenAnswer((_) => Future.value(null));
});
loadWidget(WidgetTester tester) async {
Future<void> loadWidget(WidgetTester tester) async {
await testApp(
tester,
ChangeNotifierProvider.value(

6
compass_app/app/test/ui/search_form/view_models/search_form_viewmodel_test.dart
View File

@@ -2,9 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:compass_app/ui/search_form/view_models/search_form_viewmodel.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:compass_app/ui/search_form/view_models/search_form_viewmodel.dart';
import '../../../../testing/fakes/repositories/fake_continent_repository.dart';
import '../../../../testing/fakes/repositories/fake_itinerary_config_repository.dart';
@@ -28,7 +28,7 @@ void main() {
});
test('Setting dateRange updates correctly', () {
final DateTimeRange newDateRange = DateTimeRange(
final newDateRange = DateTimeRange(
start: DateTime(2024, 1, 1),
end: DateTime(2024, 1, 31),
);
@@ -59,7 +59,7 @@ void main() {
viewModel.guests = 2;
viewModel.selectedContinent = 'CONTINENT';
final DateTimeRange newDateRange = DateTimeRange(
final newDateRange = DateTimeRange(
start: DateTime(2024, 1, 1),
end: DateTime(2024, 1, 31),
);

2
compass_app/app/test/ui/search_form/widgets/search_form_date_test.dart
View File

@@ -4,8 +4,8 @@
import 'package:compass_app/ui/search_form/view_models/search_form_viewmodel.dart';
import 'package:compass_app/ui/search_form/widgets/search_form_date.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import '../../../../testing/app.dart';
import '../../../../testing/fakes/repositories/fake_continent_repository.dart';

2
compass_app/app/test/ui/search_form/widgets/search_form_guests_test.dart
View File

@@ -4,8 +4,8 @@
import 'package:compass_app/ui/search_form/view_models/search_form_viewmodel.dart';
import 'package:compass_app/ui/search_form/widgets/search_form_guests.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import '../../../../testing/app.dart';
import '../../../../testing/fakes/repositories/fake_continent_repository.dart';

2
compass_app/app/test/ui/search_form/widgets/search_form_submit_test.dart
View File

@@ -45,7 +45,7 @@ void main() {
// Fill in data
viewModel.guests = 2;
viewModel.selectedContinent = 'CONTINENT';
final DateTimeRange newDateRange = DateTimeRange(
final newDateRange = DateTimeRange(
start: DateTime(2024, 1, 1),
end: DateTime(2024, 1, 31),
);

2
compass_app/app/test/utils/command_test.dart
View File

@@ -48,7 +48,7 @@ void main() {
});
test('should only run once', () async {
int count = 0;
var count = 0;
final command = Command0<int>(() => Future.value(Result.ok(count++)));
final future = command.execute();