1
0
mirror of https://github.com/flutter/samples.git synced 2026-07-01 18:47:32 +00:00
Commit Graph

8 Commits

Author SHA1 Message Date
Aleksandr Lozhkovoi
a6754b4515 Migrate ios_books SceneDelegate for UIScene (#2845)
Part of flutter/flutter#176957

Migrated SceneDelegate.swift to use UI scene using this guideline
https://docs.flutter.dev/release/breaking-changes/uiscenedelegate#migration-guide-for-flutter-apps
for ios_books app

<img width="1931" height="1080" alt="image"
src="https://github.com/user-attachments/assets/425f7cee-205b-4cf5-82fa-d95ff8227c1e"
/>

While testing this sample locally, I noticed a separate existing issue
in `IosBooks/ViewController.swift`: the Google Books response is
force-unwrapped. The unauthenticated request currently returns HTTP
429/quota errors in some environments, so `json["items"] as! [[String:
Any]]` can crash at runtime.

I kept this PR scoped to the UIScene migration only, but I can file or
send a separate follow-up to make the sample parse the API response
defensively, WDYT?


## Pre-launch Checklist

- [x] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [x] I signed the [CLA].
- [x] I read the [Contributors Guide].
- [x] I have added sample code updates to the [changelog].
- [x] I updated/added relevant documentation (doc comments with `///`).


If you need help, consider asking for advice on the #hackers-devrel
channel on [Discord].

<!-- Links -->
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[Contributors Guide]:
https://github.com/flutter/samples/blob/main/CONTRIBUTING.md
[changelog]: ../CHANGELOG.md

Co-authored-by: Eric Windmill <eric@ericwindmill.com>
2026-06-19 16:30:12 -07:00
xster
ce35e45702 add thumbnails to the books example to make memory leaks easier to test (#1353)
* add thumbnails to the books example to make memory leaks easier to test

* also add profile build

* migrate material 3 demo code to avoid warning

* Revert "migrate material 3 demo code to avoid warning"

This reverts commit 7df37d9f65.

* fix lints in various packages

* DoNothingAndStopPropagationIntent const conflicts between stable and beta, add lint ignore for now
2022-08-23 23:45:12 -07:00
Brett Morgan
4af443d33f Drop lock files from repo (#1282) 2022-05-28 07:01:26 +10:00
Jenn Magder
c6bee7aa93 Add-to-app iOS flutter_post_install post_install hook (#1079) 2022-04-15 23:40:50 +10:00
Brett Morgan
5b0a6be873 Drop DEVELOPMENT_TEAM (#975) 2022-01-05 06:29:30 +11:00
Andrew Brogdon
4cac0e6661 Lands beta branch into master for 2.5 (#895) 2021-09-08 17:35:05 -07:00
gaaclarke
e43698fa01 updated add_to_app sample to pigeon 1.0 (#894) 2021-09-08 11:07:11 -07:00
gaaclarke
5adf66ba65 Added iOS example for add-to-app Pigeon (#722) 2021-03-03 21:04:28 -08:00